Miku, > The field in question is declared in > arch/arm/plat-omap/include/dspbridge/_chnl_sm.h in line 120 as > u32, so checking for negative value makes no sense unless you > modify struct SHM too. -- You are right. I missed checking the declaration in _chnl_sm.h Thank you, Best regards, Hari > -----Original Message----- > From: mika.kukkonen@xxxxxxxxx [mailto:mika.kukkonen@xxxxxxxxx] > Sent: Monday, April 20, 2009 12:23 AM > To: Kanigeri, Hari; Gupta, Ramesh; ameya.palande@xxxxxxxxx > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] [DSPBRIDGE] Various compile warning fixes > > >-----Original Message----- > >From: linux-omap-owner@xxxxxxxxxxxxxxx > >[mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of ext > >Kanigeri, Hari > >Sent: 17 April, 2009 17:21 > >To: Gupta, Ramesh; Palande Ameya (Nokia-D/Helsinki); > >linux-omap@xxxxxxxxxxxxxxx > >Subject: RE: [PATCH] [DSPBRIDGE] Various compile warning fixes > > > >Ameya, > > > >- if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) { > >+ if (chnlId >= CHNL_MAXCHANNELS) { > > > >-- How about declaring chnlId as s32 so that the checks can be > >extended to negative values too ? > > The field in question is declared in > arch/arm/plat-omap/include/dspbridge/_chnl_sm.h in line 120 as > u32, so checking for negative value makes no sense unless you > modify struct SHM too. > > --MiKu -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
