Ameya, - if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) { + if (chnlId >= CHNL_MAXCHANNELS) { -- How about declaring chnlId as s32 so that the checks can be extended to negative values too ? Thank you, Best regards, Hari -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html