Hi, > From: Roger Quadros > Sent: Thursday, April 14, 2016 8:32 PM > > On 14/04/16 14:15, Yoshihiro Shimoda wrote: > > Hi, > > < snip > > >>> @@ -865,7 +867,8 @@ int usb_otg_register_hcd(struct usb_hcd *hcd, unsigned int irqnum, > >>> * we're ready only if we have shared HCD > >>> * or we don't need shared HCD. > >>> */ > >>> - if (otg->shared_hcd.hcd || !otg->primary_hcd.hcd->shared_hcd) { > >>> + if (otg->shared_hcd.hcd || (!otg->caps->needs_companion && > >>> + !otg->primary_hcd.hcd->shared_hcd)) { > >>> otg->host = hcd_to_bus(hcd); > >>> /* FIXME: set bus->otg_port if this is true OTG port with HNP */ > >>> > >> > >> These changes look good to me. Thanks. > > > > Thank you for the comment. > > If we change the "needs_companion" place to the otg_config, > > do we need to add a flag into the otg, instead of otg->caps? > > Yes we can add a flag in struct usb_otg. Thank you for the comment. I made a fixed patch. So, should I send this patch to ML after you sent v7 patches? Or, would you apply this patch before you send v7 patches? Best regards, Yoshihiro Shimoda --- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html