The PWM stuff worked with what was in linux-next. I didn't have to do
any extra patches or anything. (Thanks to David Rivshin for helping
me figure that out)
PIN_OFF_OUTPUT_LOW was set to minimize power consumption during sleep.
Looking at Logic PD's stock BSP, they have those pins enabled, and it
seemed to help me cut power with "echo mem > /sys/power/state"
If you would prefer that I not use that, I can certainly look at some
other options. Just let me know, and I can adjust the patch
accordingly.
adam
On Fri, Feb 19, 2016 at 12:43 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Adam Ford <aford173@xxxxxxxxx> [160217 16:30]:
>> The backlight pin is shared with Timer 10 PWM. This patch allows the
>> pwm_bl driver to enable the pwm run by this timer to dim the backlight.
>
> Nice to hear the PWM is now working! Are some of the pending
> fixes are still needed or is that all in Linux next now?
>
> Also one question below..
>
>> @@ -194,6 +203,12 @@
>> >;
>> };
>>
>> + pwm_pins: pinmux_pwm_pins {
>> + pinctrl-single,pins = <
>> + OMAP3_CORE1_IOPAD(0x20B8, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE3) /* gpmc_ncs5.gpt_10_pwm_evt */
>> + >;
>> + };
>> +
>> led_pins: pinmux_led_pins {
>> pinctrl-single,pins = <
>> OMAP3_CORE1_IOPAD(0x21d8, PIN_OUTPUT | MUX_MODE4) /* gpio_179 */
>> @@ -220,7 +235,6 @@
>>
>> backlight_pins: pinmux_backlight_pins {
>> pinctrl-single,pins = <
>> - OMAP3_CORE1_IOPAD(0x20B8, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE4) /* gpmc_ncs5.gpio_56 */
>> OMAP3_CORE1_IOPAD(0x2188, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE4) /* mcbsp4_dx.gpio_154 */
>> >;
>> };
>
> What happens here if you don't set PIN_OFF_OUTPUT_LOW? Flickering
> on LCD or something?
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
