Re: [PATCH] OMAP3LOGIC: Add PWM-Backlight

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Adam Ford <aford173@xxxxxxxxx> [160217 16:30]:
> The backlight pin is shared with Timer 10 PWM.  This patch allows the
> pwm_bl driver to enable the pwm run by this timer to dim the backlight.

Nice to hear the PWM is now working! Are some of the pending
fixes are still needed or is that all in Linux next now?

Also one question below..

> @@ -194,6 +203,12 @@
>  		>;
>  	};
>  
> +	pwm_pins: pinmux_pwm_pins {
> +		pinctrl-single,pins = <
> +			OMAP3_CORE1_IOPAD(0x20B8, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE3)       /* gpmc_ncs5.gpt_10_pwm_evt */
> +		>;
> +	};
> +
>  	led_pins: pinmux_led_pins {
>  		pinctrl-single,pins = <
>  			OMAP3_CORE1_IOPAD(0x21d8, PIN_OUTPUT | MUX_MODE4)	/* gpio_179 */
> @@ -220,7 +235,6 @@
>  
>  	backlight_pins: pinmux_backlight_pins {
>  		pinctrl-single,pins = <
> -			OMAP3_CORE1_IOPAD(0x20B8, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE4)       /* gpmc_ncs5.gpio_56 */
>  			OMAP3_CORE1_IOPAD(0x2188, PIN_OUTPUT | PIN_OFF_OUTPUT_LOW | MUX_MODE4)       /* mcbsp4_dx.gpio_154 */
>  		>;
>  	};

What happens here if you don't set PIN_OFF_OUTPUT_LOW? Flickering
on LCD or something?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux