Re: [PATCH v12 2/4] PM / Domains: add setter for dev.pm_domain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 7, 2016 at 5:46 PM, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> wrote:
> Adds a function that sets the pointer to dev_pm_domain in struct device
> and that warns if the device has already finished probing. The reason
> why we want to enforce that is because in the general case that can
> cause problems and also that we can simplify code quite a bit if we can
> always assume that.
>
> This patch also changes all current code that directly sets the
> dev.pm_domain pointer.


> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c

> @@ -875,13 +876,14 @@ static int acpi_lpss_platform_notify(struct notifier_block *nb,
>
>         switch (action) {
>         case BUS_NOTIFY_BIND_DRIVER:
> -               pdev->dev.pm_domain = &acpi_lpss_pm_domain;
> +               dev_pm_domain_set(&pdev->dev, &acpi_lpss_pm_domain);
>                 break;
>         case BUS_NOTIFY_DRIVER_NOT_BOUND:
>         case BUS_NOTIFY_UNBOUND_DRIVER:
>                 pdev->dev.pm_domain = NULL;

Missed?

>                 break;
>         case BUS_NOTIFY_ADD_DEVICE:
> +               dev_pm_domain_set(&pdev->dev, &acpi_lpss_pm_domain);
>                 if (pdata->dev_desc->flags & LPSS_LTR)
>                         return sysfs_create_group(&pdev->dev.kobj,
>                                                   &lpss_attr_group);
> @@ -889,6 +891,7 @@ static int acpi_lpss_platform_notify(struct notifier_block *nb,
>         case BUS_NOTIFY_DEL_DEVICE:
>                 if (pdata->dev_desc->flags & LPSS_LTR)
>                         sysfs_remove_group(&pdev->dev.kobj, &lpss_attr_group);
> +               dev_pm_domain_set(&pdev->dev, NULL);
>                 break;
>         default:
>                 break;

This looks wrong. I didn't test yet, but I have concerns here. Why did
you add those calls?

Have you been aware about the commit b5f88dd1d6ef ("Revert "ACPI /
LPSS: allow to use specific PM domain during ->probe()") ?

Sorry for being too late with this.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux