> I see why arch_timer_freq might skip the rounding error of 39, 15 and > 55 Vs existing logic which is possibly at a truncation error risk > (without errata for sysclk 13, 26 and 27MHz). > > all you'd probably need to do is cast rate, num and den to unsigned > long and have a common computation logic. If that is acceptable, then sure I can do that. I liked avoiding casts in general though. > if you'd really want to handle truncation error, it must be a separate > patch of it's own - I would not mix it with the errata fix. Well there is no error in the existing code because the rate / den is always a clean integer division. The problem is introduced by the SYSCLK1 / 610 used by the emulated clock which is not a clean division. So for the existing logic, the calculation was perfect. It is only for the errata case that it is a problem. So I think leaving the existing calculation but moved up works well, and then having the alternate order calculation only in the errata case seemed cleaner and avoids casts and 64bit math which I thought was overall desirable. -- Len Sorensen -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
