On Tue, 15 Jul 2014, Felipe Balbi wrote: > ml->node and sl->node are currently initialized > by means of INIT_LIST_HEAD(). That initialiation > is followed by a list_add() call. > > Looking at what both these functions do we will have: > > ml->node.next = &ml->node; > ml->node.prev = &ml->node; > oi->master->master_ports.next.prev = &ml->node; > ml->node.next = &oi->master->master_ports.next; > ml->node.prev = &oi->master->master_ports; > oi->master->master_ports.next = &ml->node; > > from this, it's clear that both INIT_LIST_HEAD() calls > are unnecessary and can be safely removed. > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > --- > > found by code inspection, boot tested on am437x SK on today's > linux-next + pending patches. Thanks, queued for v3.18. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
