Hi, * Pillai, Manikandan <mani.pillai@xxxxxx> [090109 05:27]: > Pls see my responses inline. > > > -----Original Message----- > > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > > Sent: Thursday, January 08, 2009 8:57 PM > > To: Pillai, Manikandan > > Cc: linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/1] OMAP3 EVM MMC1 support for TPS based PR785 power > > modules <snip> > > > > How about try to figure out a way to share the common code with > > mmc-twl4030.c? > [Pillai, Manikandan] Most of the code is derived from mmc-twl4030.c file. > The intention was to have a different file for mmc-pr785.c. Are you suggesting > here that I break the mmc-xxxx.c into 2 files mmc-shared.c and mmc-twl/pr785.c ? Yeah we could have some shared file for those functions. How about arch/arm/mach-omap2/hsmmc.c for the shared functions? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
