Re: [PATCH 1/2] Add support for GPIO LEDs on pandora

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Koen Kooi <k.kooi@xxxxxxxxxxxxxxxxxx> [090108 16:56]:
>
> Op 8 jan 2009, om 15:32 heeft Tony Lindgren het volgende geschreven:
>
>> * Grazvydas Ignotas <notasas@xxxxxxxxx> [081127 12:04]:
>>> Pandora has some LEDs and backlights connected to OMAP
>>> GPIOs and TWL4030/TPS65950 LED/PWM signals. This patch
>>> registers them all with leds-gpio driver. TWL4030/TPS65950
>>> controlled ones will be switched to PWM driver when it's ready.
>>
>> Pushing to l-o tree and adding to omap3-upstream queue for next
>> merge window. Not adding the defconfig changes to upstream queue
>> right now as the patch does not apply.
>>>
>>> +		.name			= "pandora::lcd_bl",
>>> +		.default_trigger	= "backlight",
>>> +		.gpio			= -EINVAL,
>>>
>
> That's a wrong usage of the 'backlight' trigger, which shouldn't get  
> into mainline since it sets a bad example. The backlight trigger is  
> meant to sync leds with the backlight (e.g. dim keypad leds), not to  
> make leds a backlight.

OK, thanks, dropping from l-o and omap3-upstream.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux