Re: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP Front end

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 15, 2008 at 08:12:41AM -0800, Tony Lindgren wrote:
> You should not need cpu_is_omapXXXX() macros in the drivers. Please
> set up the configuration in platform_data.
> 
> Also, please pass the IORESOURCE from platform_data, and then ioremap
> it in the driver. That way you can use __raw_read/write instead of
> __omap_read/write.

just one reminder. IORESOURCE_* goes via struct resource. Then you use
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); and ioremap()
afterwards.

Similar should be done for the IRQ, but using IORESOURCE_IRQ and
platform_get_irq(pdev, 0);

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux