RE: [REVIEW PATCH 14/14] OMAP34XX: CAM: Add Sensors Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Tony Lindgren [mailto:tony@xxxxxxxxxxx]
> * Aguirre Rodriguez, Sergio Alberto <saaguirre@xxxxxx> [081211 12:44]:
> > +	case V4L2_POWER_OFF:
> > +		/* Power Down Sequence */
> > +#ifdef CONFIG_TWL4030_CORE
> > +		twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
> > +				VAUX_DEV_GRP_NONE, TWL4030_VAUX2_DEV_GRP);
> > +#else
> > +#error "no power companion board defined!"
> > +#endif
> 
> These checks look unecessary. How about just handle it with Kconfig?
> 
[Aguirre, Sergio] But how? Don't you think that if I do that, I'll tighten the sensor driver to this board only?

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux