Re: [PATCH 5/6] ARM: OMAP2: drop redundant pending write check for gptimer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 04, 2008 at 06:41:21PM -0800, Tony Lindgren wrote:
> omap_dm_timer_write_reg() already waits for pending writes to complete,
> so the extra wait in omap_dm_timer_set_load() is superfluous.

Is this right?  I mean - do you have to wait for each individual write
to each register to complete before writing the next (and different)
register?

Given that the code waits for every write to complete, no wonder Richard
Woodruff is complaining that the NOHZ code is poor (it isn't) - with three
writes each waiting for the previous to complete- what was it, 78us each,
to complete?  That's 234us just to reprogram the timer hardware with the
CPU spinning waiting for each of the posted writes to complete.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux