RE: [PATCH] Add OMAP2 camera driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Sakari Ailus wrote:
> ext Hiremath, Vaibhav wrote:
> > OMAP3 -
> > 	Display - (Posted twice with old DSS library)
> > 		- omap_vout.c
> > 		- omap_voutlib.c
> > 		- omap_voutlib.h
> > 		- omap_voutdef.h
> > 	Camera - (Will come soon)
> > 		- omap34xxcam.c
> > 		- omap34xxcam.h
> > 	ISP - (Will come soon)
> > 		- Here definitely we will plenty number of files.
> 
> I think that the OMAP 3 stuff could go into a separate directory, say
> omap3 or omap3isp. But for the OMAP 1 or OMAP 2 camera drivers, I'd
> perhaps just prefix those with corresponding OMAP (omap1 etc.).
> 
> The current OMAP 3 camera driver has few dependencies to OMAP 3 left so
> it seems that it's going to be generic. It's just a question of when the
> OMAP 3 ISP driver can offer a better interface towards the camera driver.
> 
[Aguirre, Sergio] Hi, I have some comments about this:

IMHO, I think that we can keep same names for OMAP3 camera driver, and keep it at the same level than omap1 and omap2 cam drivers, but for isp folder, I agree with Sakari that has to be named omap3isp.

Although the end result of making OMAP3 cam driver independent from ISP doesn't make much sense to me, as in OMAP3 the ISP is needed even for the minimal handling required for receiving data from the sensors that the camera driver supports. (Minimal datapath is CCP2->SDRAM or CSI2->SDRAM, and that requires ISP MMU and the corresponding receivers, which are considered part of the ISP)

About display filenames, if they are compatible with all OMAP versions (1, 2, 3), then current name makes sense, if no, then omap3_vout* will look clearer.

What do you think?

Regards,
Sergio

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux