Hi,
* Jarkko Nikula <jarkko.nikula@xxxxxxxxx> [081014 23:03]:
> On Tue, 14 Oct 2008 10:19:08 -0700
> "ext Tony Lindgren" <tony@xxxxxxxxxxx> wrote:
>
> > > Please take a look and resolve ASAP. Thanks.
> >
> > Sorry for the delay, I was sitting in an airplane again.
> >
> > Here's the fix, looks like the missing McBSP irqs should have been
> > merged into the recent McBSP patches.
> >
> > This patch is also in your patch system as 5301/1.
> >
> Tony,
>
> If my patch below from linux-omap was forgotten from original pull
> request, please note that it's required to add those rx/tx irqs into
> omap_mcbsp_platform_data structs in arch/arm/mach-omap2/mcbsp.c as
> well. Otherwise arch/arm/plat-omap/mcbsp.c: omap_mcbsp_request will
> fail when requesting zero defined irqs.
>
> Sorry, not noting this before.
>
>
> Jarkko
>
> commit c29cfcead32c8dcb9738a085d498aebe6ab160af
> Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
> Date: Tue Sep 16 15:56:53 2008 +0300
>
> ARM: OMAP: Add RX/TX interrupts for 2430 and 34xx McBSP ports 3-5
>
> Without RX and TX interrupt definitions, the omap_mcbsp_request will
> fail on OMAP2430 and OMAP34xx for ports 3-5 since default io_type is
> OMAP_MCBSP_IRQ_IO.
It's there, in Russell's omap-all branch. I just merged your fix
into your other patch:
commit 05228c35c67995c745ae3c768eaf90740c643fa9
Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
Date: Wed Oct 8 10:01:40 2008 +0300
ARM: OMAP: Add support for OMAP2430 in McBSP
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
