On Mon, 29 Sep 2008 10:46:33 +0530
"ext Arun KS" <arunks@xxxxxxxxxxxxxxxxxxxx> wrote:
> The system hangs when there is a request for mcbsp in the platform
> driver of omap ie.. at
> File:sound/soc/omap/omap-mcbsp.c
> Function: omap_mcbsp_dai_startup
> omap_mcbsp_request(mcbsp_data->bus_id);
> This is executed when we do an aplay.
>
Was this patch included?
commit f9d06c24f43b7620b14e4dd6dbf667fa68457766
Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
Date: Mon Sep 22 16:47:51 2008 +0300
ARM: OMAP: Fixes to omap_mcbsp_request function
Bootloader may let McBSP logic running so make sure that block is
idle before requesting IRQs. Also make sure that TX and RX waitqueues
are initialized before request_irq.
Also you can get some debug messages from mcbsp by patch below and
"echo 8 > /proc/sys/kernel/printk" in your target before executing
aplay.
---
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 798c91e..2bfb177 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -12,6 +12,7 @@
* Multichannel mode not supported.
*/
+#define DEBUG
#include <linux/module.h>
#include <linux/init.h>
#include <linux/device.h>
---
> In the ALSA driver(sound/arm/omap/omap-alsa.c:513) the
> omap_mcbsp_request() is during the boot time.
> There no issues.
>
> So during my testing of the ASOC driver i comment out
> omap_mcbsp_request(mcbsp_data->bus_id); from
> platform driver (sound/soc/omap/omap-mcbsp.c) and insted requested the
> omap_mcbsp in my
> moudule_init of machine driver(ie sound/soc/omap/osk.c).
>
Legacy driver is doing some clock setup in snd_omap_alsa_post_probe
before omap_mcbsp_request.
alsa_codec_config->codec_clock_setup();
alsa_codec_config->codec_clock_on();
omap_mcbsp_request(AUDIO_MCBSP);
If my patch wasn't included I can understand that it would explain why
legacy driver is working. If it was, then there still might be some
registers which must be set to reset default before requesting irqs in
omap_mcbsp_request.
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
