On Mon, Sep 29, 2008 at 1:14 PM, Jarkko Nikula <jarkko.nikula@xxxxxxxxx> wrote:
> On Mon, 29 Sep 2008 10:46:33 +0530
> "ext Arun KS" <arunks@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> The system hangs when there is a request for mcbsp in the platform
>> driver of omap ie.. at
>> File:sound/soc/omap/omap-mcbsp.c
>> Function: omap_mcbsp_dai_startup
>> omap_mcbsp_request(mcbsp_data->bus_id);
>> This is executed when we do an aplay.
>>
> Was this patch included?
>
> commit f9d06c24f43b7620b14e4dd6dbf667fa68457766
> Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxx>
> Date: Mon Sep 22 16:47:51 2008 +0300
>
> ARM: OMAP: Fixes to omap_mcbsp_request function
>
> Bootloader may let McBSP logic running so make sure that block is
> idle before requesting IRQs. Also make sure that TX and RX waitqueues
> are initialized before request_irq.
This patch is included. I am using latest l-o tree.
>
> Also you can get some debug messages from mcbsp by patch below and
> "echo 8 > /proc/sys/kernel/printk" in your target before executing
> aplay.
>
> ---
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 798c91e..2bfb177 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -12,6 +12,7 @@
> * Multichannel mode not supported.
> */
>
> +#define DEBUG
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/device.h>
> ---
>
>> In the ALSA driver(sound/arm/omap/omap-alsa.c:513) the
>> omap_mcbsp_request() is during the boot time.
>> There no issues.
>>
>> So during my testing of the ASOC driver i comment out
>> omap_mcbsp_request(mcbsp_data->bus_id); from
>> platform driver (sound/soc/omap/omap-mcbsp.c) and insted requested the
>> omap_mcbsp in my
>> moudule_init of machine driver(ie sound/soc/omap/osk.c).
>>
> Legacy driver is doing some clock setup in snd_omap_alsa_post_probe
> before omap_mcbsp_request.
>
> alsa_codec_config->codec_clock_setup();
> alsa_codec_config->codec_clock_on();
>
> omap_mcbsp_request(AUDIO_MCBSP);
All these setting i had taken care off in the machine driver osk.c
>
> If my patch wasn't included I can understand that it would explain why
> legacy driver is working. If it was, then there still might be some
> registers which must be set to reset default before requesting irqs in
> omap_mcbsp_request.
Write which causes this hang is at
File: arch/arm/mach-omap1/mcbsp.c
Function: omap1_mcbsp_request
__raw_writew(__raw_readw(DSP_RSTCT2) | DPS_RSTCT2_PER_EN |
DSP_RSTCT2_WD_PER_EN, DSP_RSTCT2);
This is the exact place where the system hangs. This function is
called from omap_mcbsp_request().
If i call omap_mcbsp_request in init funciton of machine dirver(ie
osk.c), there is no problem.
Is there any memory mapping happening after booting that may result
this write to hit
some other registers?
Arun
>
>
> Jarkko
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
