MUSB not workin in .27rc6, was: Re: OMAP support in mainline?

Koen Kooi <k.kooi@xxxxxxxxxxxxxxxxxx> · Fri, 19 Sep 2008 18:09:04 +0200

Op 18 sep 2008, om 11:55 heeft Felipe Balbi het volgende geschreven:

On Wed, Sep 17, 2008 at 03:23:49PM +0200, ext Koen Kooi wrote:

Op 17 sep 2008, om 14:24 heeft Steve Sakoman het volgende geschreven:

On Wed, Sep 17, 2008 at 12:16 AM, Koen Kooi <k.kooi@xxxxxxxxxxxxxxxxxx 
>
wrote:

And they aren't working too well with current l-o git either with  
MUSB
being
broken. There's a patch to fix client mode, but host mode still  
isn't
working.

Host mode musb is working just fine on Overo with the "set
transceiver" patch.  Not sure why you are having trouble with Beagle
(and can't check since I don't have my Beagle board with me at the
moment)

I should clarify: OTG mode with a host cable doesn't work in .27rc,  
it does
work in 2.6.26. I haven't tried specifying pure hostmode, only OTG.
I would try it on the evm as well, but that is having serious irq  
issues
with .27rc, pressing a key on the keypad triggers an irq overrun,  
ethernet
gives an oops on boot when trying to register and irq etc,etc.  
2.6.27 is
looking really, really bad on omap3 at the moment.

Yeah, we lost some musb history when it went to mainline. I didn't  
test
this patch yet cuz I've been quite busy at work, but it should make
beagle work. Could you tell me if makes it work ?

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 9d2dcb1..f7fe91e 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -215,12 +215,14 @@ void musb_platform_set_mode(struct musb *musb,  
u8 musb_mode)

int __init musb_platform_init(struct musb *musb)
{
+       struct otg_transceiver *xceiv = otg_get_transceiver();
       u32 l;

#if defined(CONFIG_ARCH_OMAP2430)
       omap_cfg_reg(AE5_2430_USB0HS_STP);
#endif

+       memcpy(musb->xceiv, xceiv, sizeof(*xceiv));
       musb_platform_resume(musb);

       l = omap_readl(OTG_SYSCONFIG);

Ok, another datapoint: client mode (tested on beagle by Måns) and host  
mode (tested on overo by Steve) work with a similar patch as above,  
OTG mode is broken (tested on beagle and evm by me).

regards,

Koen


Attachment:
PGP.sig

Description: This is a digitally signed message part




