On Mon, 2008-09-15 at 20:27 +0100, ext Måns Rullgård wrote: > Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx> writes: > > > On Sat, 2008-09-13 at 22:47 +0100, ext Måns Rullgård wrote: > >> Koen Kooi <k.kooi@xxxxxxxxxxxxxxxxxx> writes: > > > >> What I don't like about the patch posted is its size. I'm sure the > >> transition could be done in a sequence of smaller patches. At the > >> very least, it should be possible to move existing functionality to > >> the new architecture, then add the new parts afterwards. I also see > >> little value in keeping the old model around, as is done in the patch. > > > > I don't like the size either. However, I have no idea how the old driver > > could be transformed to include this functionality with a reasonable > > effort. The implementations are quite different. > > > > Any suggestions how I could approach this task? Only thing that comes to > > my mind is that there are very similar low level functions in both DSS1 > > and DSS2 (for dispc and rfbi), that I could remove from the old place > > and move to arch/arm/plat-omap/dss/, but that doesn't take us very far. > > Are the patches you posted your latest version of the code? Do you > have this code in a public git repo? I'd like to take a closer look > at what you've done. They are not the very latest, but they are recent enough. Unfortunately I don't have them on a public git. Nokia is still a bit lacking in that area =). They should apply to linux-omap kernel from last Thursday (I think the commit id is mentioned in the series file). Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
