RE: [patch] omap: usb: ehci: fix use of hcd->regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe
> -----Original Message-----
> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Hiroshi
> > > >
> > > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> > > > index 8f122e5..a67533d 100644
> > > > --- a/drivers/usb/host/ehci-omap.c
> > > > +++ b/drivers/usb/host/ehci-omap.c
> > > > @@ -438,7 +438,7 @@ static int ehci_hcd_omap_drv_probe(struct platform_device *dev)
> > > >         hcd->rsrc_start = dev->resource[0].start;
> > > >         hcd->rsrc_len = dev->resource[0].end - dev->resource[0].start + 1;
> > > >
> > > > -       hcd->regs = (void __iomem *) (int) IO_ADDRESS(hcd->rsrc_start);
> > > > +       hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len);

I have seen this ioremap() call causes problems on OMAP34xx/24xx as the reg memory is already mapped.
Will have to check on the board once.

> > >
> > > Return value check?
> >
> > Good one. Here's a new version:
> >
> > ===== cut here ====
> >
> > From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > Subject: [patch] omap: usb: ehci: fix usb of hcd->regs
> >
> > hcd->regs should be initialized by ioremaping hcd->rsrc_start and
> > hcd->rsrc_len. Fix it for ehci-omap.c.
> 
> Acked-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
> 
> > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux