> -----Original Message----- > From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] > Sent: Saturday, September 13, 2008 1:06 AM > To: Felipe Balbi > Cc: Tony Lindgren; David Brownell; felipe.balbi@xxxxxxxxx; Linux OMAP Mailing List; Pandita, Vikram > Subject: Re: [rfc] [patch] clean up to ehci-omap (Was: Re: [patch] omap: usb: ehci: fix use of hcd- > >regs) > > Hi Vikram, > > Those "issues" mentioned on the ehci-omap driver, are them silicon > version related ? I mean, does it happen on all omap3 silicons or > doesn't it happen with only versions of them ? The issues mentioned are _not_ of omap34xx silicon, but of the PHY (ISP1504 in SDP-USB expansion board). > > Case the second, we can make the workarounds be applied based on runtime > checks instead of #ifdefs. That would look nice. Better still is to move the PHY issues to platform/board specific function. Will try to submit a patch on that. > > Also, it looks like PHY and TLL mode will be board specific, which means > we can use a platform_data to pass the correct mode to the driver and > get rid of those #ifdefs and Kconfig choices as well. Yes that can be done. > > Any comments ? > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
