> > + /* All the partition sizes are listed in terms of NAND block size > > ... > > + .size = SZ_512K, > > ... > > + .size = SZ_512K, > > ... > > But now they're not "in terms of NAND block size". Agree. > > Wouldn't it be better to use either 4 * SZ_128K or 4 * NAND_BLOCK_SIZE? 4 * NAND_BLOCK_SIZE looks much better. I'll send patch after updating for this. I will define NAND_BLOCK_SIZE as: #define NAND_BLOCK_SIZE 64 * NAND_MAX_PAGESIZE-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html