Re: [PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 08, 2008 at 09:02:56PM +0100, ext Måns Rullgård wrote:
> "arun c" <arunedarath@xxxxxxxxxxxxxxxxxxxx> writes:
> > +	while (dispc_read_reg(DISPC_CONTROL) & (1 << 5))
> > +		continue;
> > +	MOD_REG_FLD(DISPC_CONTROL, 1 << 5, 1 << 5);
> > +
> >  	return height * screen_width * bpp / 8;
> >  }
> 
> This looks good.  However, the same thing is needed in
> omap_dispc_enable_plane() as well.  Placing the loop+set in a function
> (go_lcd()?) would make sense.

Preferably something with a slightly more generic name, so it could
also fire GODIGITAL for digital out, when support for that exists.

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux