"arun c" <arunedarath@xxxxxxxxxxxxxxxxxxxx> writes: > A shadow register change has no direct effect on the display > configuration until the GOLCD (DISPC_CONTROL[5]) is set. > > Signed-off-by: Arun C <arunedarath@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/video/omap/dispc.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c > index 82ba030..2e7af85 100644 > --- a/drivers/video/omap/dispc.c > +++ b/drivers/video/omap/dispc.c > @@ -436,6 +436,11 @@ static inline int _setup_plane(int plane, int channel_out, > > dispc_write_reg(ri_reg[plane], (screen_width - width) * bpp / 8 + 1); > > + /* Wait untill GOLCD bit is cleared and set it */ Nit: "until" (one l) > + while (dispc_read_reg(DISPC_CONTROL) & (1 << 5)) > + continue; > + MOD_REG_FLD(DISPC_CONTROL, 1 << 5, 1 << 5); > + > return height * screen_width * bpp / 8; > } This looks good. However, the same thing is needed in omap_dispc_enable_plane() as well. Placing the loop+set in a function (go_lcd()?) would make sense. -- Måns Rullgård mans@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
