Felipe, I corrected the indentation as well as the initialization of clkdm, I'll resend the new patch. About the OMAP3430_EN_CSI2 and OMAP3430_EN_CSI2_SHIFT defines, they look aligned in the final file, although in the patch looks unaligned. That space in the beginning of the patch line seems to be critical to look aligned... :/ Thanks for your time. Regards, Sergio -----Original Message----- From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] Sent: Tuesday, September 02, 2008 5:38 PM To: Aguirre Rodriguez, Sergio Alberto Cc: Paul Walmsley; linux-omap@xxxxxxxxxxxxxxx Subject: Re: [RESEND][Review Request] Adding csi2_fck declaration to clock34xx.h On Tue, Sep 02, 2008 at 05:33:55PM -0500, Aguirre Rodriguez, Sergio Alberto wrote: > +static struct clk csi2_96m_fck = { > + .name = "csi2_96m_fck", > + .parent = &core_96m_fck, > + .init = &omap2_init_clk_clkdm, > + .enable_reg = _OMAP34XX_CM_REGADDR(OMAP3430_CAM_MOD, CM_FCLKEN), > + .enable_bit = OMAP3430_EN_CSI2_SHIFT, > + .flags = CLOCK_IN_OMAP343X, > + .clkdm = { .name = "cam_clkdm" }, > + .recalc = &followparent_recalc, > +}; do not use spaces for identation, I think it's a mailer problem. Try to use git send-email. Also, clkdm should be initialized as: .clkdm = { .name = "cam_clkdm", }, > /* CM_FCLKEN_CAM specific bits */ > +#define OMAP3430_EN_CSI2 (1 << 1) > +#define OMAP3430_EN_CSI2_SHIFT 1 align these with the rest of the file -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
