Re: [RESEND][Review Request] Adding csi2_fck declaration to clock34xx.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 02, 2008 at 05:33:55PM -0500, Aguirre Rodriguez, Sergio Alberto wrote:
> +static struct clk csi2_96m_fck = {
> +        .name           = "csi2_96m_fck",
> +        .parent         = &core_96m_fck,
> +        .init           = &omap2_init_clk_clkdm,
> +        .enable_reg     = _OMAP34XX_CM_REGADDR(OMAP3430_CAM_MOD, CM_FCLKEN),
> +        .enable_bit     = OMAP3430_EN_CSI2_SHIFT,
> +        .flags          = CLOCK_IN_OMAP343X,
> +	.clkdm		= { .name = "cam_clkdm" },
> +        .recalc         = &followparent_recalc,
> +};

do not use spaces for identation, I think it's a mailer problem. Try to
use git send-email. Also, clkdm should be initialized as:

	.clkdm		= {
		.name	= "cam_clkdm",
	},

>  /* CM_FCLKEN_CAM specific bits */
> +#define OMAP3430_EN_CSI2				(1 << 1)
> +#define OMAP3430_EN_CSI2_SHIFT				1

align these with the rest of the file

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux