On ti, 2008-08-05 at 13:50 +0300, ext Tony Lindgren wrote: > * Peter 'p2' De Schrijver <peter.de-schrijver@xxxxxxxxx> [080721 19:03]: > > > > Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@xxxxxxxxx> > > --- > > arch/arm/mach-omap2/smartreflex.c | 10 +++++----- > > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c > > index 0f3a659..b41fe96 100644 > > --- a/arch/arm/mach-omap2/smartreflex.c > > +++ b/arch/arm/mach-omap2/smartreflex.c > > @@ -396,17 +396,17 @@ static void sr_configure_vc(void) > > > > /* Setup voltctrl and other setup times */ > > /* XXX CONFIG_SYSOFFMODE has not been implemented yet */ > > -#ifdef CONFIG_SYSOFFMODE > > - prm_write_mod_reg(OMAP3430_AUTO_OFF | OMAP3430_AUTO_RET, > > - OMAP3430_GR_MOD, > > +#ifdef CONFIG_OMAP_SYSOFFMODE > > + prm_write_mod_reg(OMAP3430_AUTO_OFF | OMAP3430_AUTO_RET | > > + OMAP3430_SEL_OFF, OMAP3430_GR_MOD, > > OMAP3_PRM_VOLTCTRL_OFFSET); > > > > prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD, > > OMAP3_PRM_CLKSETUP_OFFSET); > > prm_write_mod_reg((OMAP3430_VOLTSETUP_TIME2 << > > - OMAP3430_VOLTSETUP_TIME2_OFFSET) | > > + OMAP3430_SETUP_TIME2_SHIFT) | > > (OMAP3430_VOLTSETUP_TIME1 << > > - OMAP3430_VOLTSETUP_TIME1_OFFSET), > > + OMAP3430_SETUP_TIME1_SHIFT), > > OMAP3430_GR_MOD, OMAP3_PRM_VOLTSETUP1_OFFSET); > > > > prm_write_mod_reg(OMAP3430_VOLTOFFSET_DURATION, OMAP3430_GR_MOD, > > Do we need the CONFIG_SYSOFFMODE option? How about just add > /sys/power/off_while_idle and if that's set to 1 then allow off mode? I would say no, we don't need the CONFIG_SYSOFFMODE option. I think we can always use 0 volt sys off mode for suspend, since it's user activated and the wake-up latency is still in range of only few ms. Dynamic idle is bit different, because the system would have to be idle a lot longer for the 0V off mode to pay off (when comparing to sleep voltage off mode). We could have an extra C-state in the upcoming cpu-idle driver for 0 volt off-mode. Richard, Rajendra, any thoughts? If that's not feasible, the "off_while_idle" sysfs interface can be created. Br, Kalle > > Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
