On Mon, 16 Jun 2008 17:50:58 +0530 "ext Chandra shekhar" <x0044955@xxxxxx> wrote: > > Signed-off-by: chandra shekhar <x0044955@xxxxxx> > --- > arch/arm/configs/omap_3430sdp_defconfig | 1 > arch/arm/mach-omap2/mcbsp.c | 45 ++++++++++++++++++++++ > ++++++++++ arch/arm/plat-omap/mcbsp.c | 2 - > include/asm-arm/arch-omap/mcbsp.h | 34 +++++++++++++++++++++ > +-- 4 files changed, 79 insertions(+), 3 deletions(-) ... > +#define OMAP_MCBSP_BIT(ARG) ((0x01)<<(ARG)) > > +#define DILB OMAP_MCBSP_BIT(5) > This OMAP_MCBSP_BIT(ARG) is needless. Usual (1 << 5) convention would be better or follow the same 0x0020 convention what mcbsp.h is doing currently. Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
