Hi Paul >Sent: Tuesday, February 12, 2008 5:18 AM > > >drivers/usb/host/ehci-omap.c in the git tree doesn't compile when >CONFIG_OMAP_EHCI_PHY_MODE is disabled; error message is enclosed below. >Fix the bug, and while there, rearrange the source code to reduce code >duplication and function size. > >Vikram, can you give this patch a look to see if it makes sense? It's >been compile-tested only. > > CC [M] drivers/usb/host/ehci-hcd.o >In file included from drivers/usb/host/ehci-hcd.c:958: >drivers/usb/host/ehci-omap.c: In function 'omap_start_ehc': >drivers/usb/host/ehci-omap.c:293: error: 'OMAP_TLL_ULPI_SCRATCH_REGISTER' undeclared (first use in >this function) >drivers/usb/host/ehci-omap.c:293: error: (Each undeclared identifier is reported only once >drivers/usb/host/ehci-omap.c:293: error: for each function it appears in.) > >Signed-off-by: Paul Walmsley <paul@xxxxxxxxx> > > >- Paul > > >--- > drivers/usb/host/ehci-omap.c | 141 +++++++++++++++++++------------------------ > drivers/usb/host/ehci-omap.h | 2 > 2 files changed, 65 insertions(+), 78 deletions(-) ACK and tested on SDP3430 I will resubmit your patch with minor changes as suggested by David. And then I will go to fix other long-list of changes suggested by David :-) - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
