Re: [PATCH] OMAP34xx USB: fix compile breakage in TLL mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 11 February 2008, Paul Walmsley wrote:
> +
> +#ifndef CONFIG_OMAP_EHCI_PHY_MODE
> +
> +static void omap_usb_utmi_init(struct platform_device *dev, struct usb_hcd *hcd)
> +{
> +       ...

That's also a good start on some of the cleanups I mentioned.

Though I would pass a "struct device *dev", since it doesn't
really need to know a thing about usbcore ... and also pass
in a mask describing which channels to use, since I'd expect
most boards won't need all three channels.

- Dave


-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux