> -----Original Message----- > From: Anderson Lizardo [mailto:anderson.lizardo@xxxxxxxxx] > Sent: Friday, February 15, 2008 8:46 PM > To: Madhusudhan Chikkature Rajashekar > Cc: Tony Lindgren; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] HDQ driver update > > Hi, > > On Thu, Feb 14, 2008 at 8:03 AM, Madhusudhan Chikkature Rajashekar > <madhu.cr@xxxxxx> wrote: > > Index: linux-omap-2.6-hdq-rework/include/asm-arm/arch-omap/hdq.h > > =================================================================== > > --- > linux-omap-2.6-hdq-rework.orig/include/asm-arm/arch-omap/hdq.h > 2008-01-28 10:46:48.000000000 +0530 > > +++ > linux-omap-2.6-hdq-rework/include/asm-arm/arch-omap/hdq.h > 2008-02-12 14:36:41.988642027 +0530 > > @@ -13,10 +13,9 @@ > > #define __ASM_OMAP2_HDQ_H__ > > > > /* Note the following APIs have to be called in a process > context */ > > -int omap_hdq_get(void); /* request the HDQ block */ > > -int omap_hdq_put(void); /* release the HDQ block */ > > -int omap_hdq_break(void); /* reset the slave by sending > it a break pulse */ > > - > > -int omap_hdq_reset(void); /* reset the HDQ block */ > > +static int omap_hdq_get(void); /* request the HDQ block */ > > +static int omap_hdq_put(void); /* release the HDQ block */ > > +/* reset the slave by sending it a break pulse */ > > +static int omap_hdq_break(void); > > If these functions are static, why put their declarations in > the header file? Thanks for the comment. I agree with your point. The declarations can very well go into the Driver file itself. I will resend the patch moving the declartions into the driver file omap_hdq.c. Regards, Madhu > > Regards, > -- > Anderson Lizardo > Instituto Nokia de Tecnologia > Manaus - Brazil > - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
