Hi Paul >From: Paul Walmsley [mailto:paul@xxxxxxxxx] > >Hi Vikram, > >a few comments on the PRM/CM portions of your patchset. OK. Suggested changes look cleaner, involving lesser defines. Will resubmit. Hopefully this should be the final rework :-) > >For module register access, please use cm_{read,write}_mod_reg(), rather >than cm_{read,write}_reg(). For example, > >cm_write_mod_reg((12 << OMAP3430ES2_PERIPH2_DPLL_DIV_SHIFT) | > (120 << OMAP3430ES2_PERIPH2_DPLL_MULT_SHIFT), > PLL_MOD, OMAP3430ES2_CM_CLKSEL4); > - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html