Hi David >From: David Brownell [mailto:david-b@xxxxxxxxxxx] >Sent: Thursday, January 17, 2008 11:23 PM >To: Pandita, Vikram > >On Thursday 17 January 2008, Pandita, Vikram wrote: >> >> The patch series adds USBHOST EHCI support to 34xx platform. >> Tested on OMAP3430SDP with USBHOST connectivity board 750-2083-001 C >> >> OMAP3430 ES2.0 has the following USB components: >> USB Core1 : MUSB(old)+ T2-Transceiver >> USB Core2 : EHCI/OHCI block (NEW) <---------- (This patch address EHCI driver for this core) >> >> Following are the patches as part of this patch series and their description: >> >> [PATCH 1/4] This patch adds EHCI menu config item for OMAP34xx > >This is out of order. The general rule is that patches should >merge in a sequence that supports "git bisect" ... but this patch >allows an unbuildable configuration. This patch adds a menu config item that is not selected by default. So I think it should not cause a build break. Else if I have not completely understood your point, could you give a suggestion? > >Also ... if this is an "EHCI/OHCI block" then you should be >adding the OHCI support too... Current h/w has a limitation of not able to have EHCI and OHCI both work at the same time on a port. So OHCI functionality is independent right now and will be added once EHCI is in. > > >> [PATCH 2/4] This patch adds EHCI TLL mux entries in mux.c and mux.h >> [PATCH 3/4] This patch adds EHCI platform specific data to OMAP34xx board file > >No comments from me on those two. > > >> [PATCH 4/4] This patch adds the EHCI glue layer to 34xx platform > >Only two quick comments on that one: > > - Please stop using the obsolete idiom of having the probe() and > remove() methods split in two needless parts. OK. Will repost the patch with the change. > > - Pending for 2.6.24-early merge is code switching EHCI debug > files to use debugfs. Please make this code stick the OMAP > registers into that framework ... specifically, don't add a > new file with some OMAP-specific registers, just add them to > the standard file. You may need to tweak the setup a bit > to alow that, maybe addding a method to struct ehci_hcd. Where can I get the patch for the debugfs EHCI debug interface? For now I can remove the OMAP specific debug and once debugfs is integrated, I can modify accordingly. Is that ok? > > >> Dependency Patches: (Not in omap GIT yet) >> mux.patch - patch sent out by Anand Gadiyar on 17th Jan,08 >> clock.patch - 34xx Clock framework patch by Paul Walmsley posted on omap mailing list on 19th >Dec,07 >> - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
