> -----Original Message----- > From: Pierre Ossman [mailto:drzeus-list@xxxxxxxxx] > Sent: Tuesday, December 18, 2007 6:01 PM > To: Madhusudhan Chikkature Rajashekar > Cc: 'Tony Lindgren'; linux-omap@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [Resending: PATCH 1/4] MMC/SD Controller driver > for OMAP2430 > > On Tue, 18 Dec 2007 16:20:25 +0530 > "Madhusudhan Chikkature Rajashekar" <madhu.cr@xxxxxx> wrote: > > > Hi, > > > > I am resending the patch after removing few double space > present in the code. > > > > Regards, > > Madhu > > > -------------------------------------------------------------- > --------------------- > > > > > > > > This patch adds MMC controller driver for OMAP2430/3430. > > > > Signed-off-by: Madhusudhan Chikkature<madhu.cr@xxxxxx> > > > > --- > > *snip* > > > Index: linux-omap-2.6/drivers/mmc/host/Makefile > > =================================================================== > > --- linux-omap-2.6.orig/drivers/mmc/host/Makefile > 2007-12-18 14:02:15.343108911 +0530 > > +++ linux-omap-2.6/drivers/mmc/host/Makefile > 2007-12-18 14:20:05.967961825 +0530 > > @@ -13,7 +13,14 @@ > > obj-$(CONFIG_MMC_RICOH_MMC) += ricoh_mmc.o > > obj-$(CONFIG_MMC_WBSD) += wbsd.o > > obj-$(CONFIG_MMC_AU1X) += au1xmmc.o > > -obj-$(CONFIG_MMC_OMAP) += omap.o > > + > > +ifeq ($(CONFIG_MMC_OMAP),y) > > +obj-$(CONFIG_ARCH_OMAP3430) += omap_hsmmc.o > > +obj-$(CONFIG_ARCH_OMAP2430) += omap_hsmmc.o > > +obj-$(CONFIG_ARCH_OMAP2420) += omap.o > > +obj-$(CONFIG_ARCH_OMAP1) += omap.o > > +endif > > + > > obj-$(CONFIG_MMC_AT91) += at91_mci.o > > obj-$(CONFIG_MMC_TIFM_SD) += tifm_sd.o > > obj-$(CONFIG_MMC_SPI) += mmc_spi.o > > > > As this is a new driver, independent of the old one, wouldn't > it make more sense with separate options? One CONFIG_MMC_OMAP > and one CONFIG_MMC_OMAP_HS. Then you can specify the relevant > dependencies in Kconfig, where they belong. Yes. I guess it makes sense. The current dependancy for enabling MMC seem to be based on ARCH_OMAP selection which is true for all the OMAP platforms.I think this needs to be changed. >From the controller point of view, OMAP1 and 2420 of OMAP2 had the controller that omap.c can support. From 2430 onwards(2430 and 3430) it is the HSMMC controller. We can have two seperate config options and base the selection of omap.c on ARCH_OMAP1 || (ARCH_OMAP2 && ARCH_OMAP2420). Then we can have MMC_OMAP_HS depending on (ARCH_OMAP2 && ARCH_OMAP2430) || ARCH_OMAP3. Even though specifing the relavent dependencies can be done with the current method also based on the board type, I beleive taking the above method of having two seperate options would be much better. I can resend my patch with this modification, if no one has any issues with this change to Kconfig. > > Rgds > -- > -- Pierre Ossman > > Linux kernel, MMC maintainer http://www.kernel.org > PulseAudio, core developer http://pulseaudio.org > rdesktop, core developer http://www.rdesktop.org > - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
