On Tue, 18 Dec 2007 16:20:25 +0530
"Madhusudhan Chikkature Rajashekar" <madhu.cr@xxxxxx> wrote:
> Hi,
>
> I am resending the patch after removing few double space present in the code.
>
> Regards,
> Madhu
> -----------------------------------------------------------------------------------
>
>
>
> This patch adds MMC controller driver for OMAP2430/3430.
>
> Signed-off-by: Madhusudhan Chikkature<madhu.cr@xxxxxx>
>
> ---
*snip*
> Index: linux-omap-2.6/drivers/mmc/host/Makefile
> ===================================================================
> --- linux-omap-2.6.orig/drivers/mmc/host/Makefile 2007-12-18 14:02:15.343108911 +0530
> +++ linux-omap-2.6/drivers/mmc/host/Makefile 2007-12-18 14:20:05.967961825 +0530
> @@ -13,7 +13,14 @@
> obj-$(CONFIG_MMC_RICOH_MMC) += ricoh_mmc.o
> obj-$(CONFIG_MMC_WBSD) += wbsd.o
> obj-$(CONFIG_MMC_AU1X) += au1xmmc.o
> -obj-$(CONFIG_MMC_OMAP) += omap.o
> +
> +ifeq ($(CONFIG_MMC_OMAP),y)
> +obj-$(CONFIG_ARCH_OMAP3430) += omap_hsmmc.o
> +obj-$(CONFIG_ARCH_OMAP2430) += omap_hsmmc.o
> +obj-$(CONFIG_ARCH_OMAP2420) += omap.o
> +obj-$(CONFIG_ARCH_OMAP1) += omap.o
> +endif
> +
> obj-$(CONFIG_MMC_AT91) += at91_mci.o
> obj-$(CONFIG_MMC_TIFM_SD) += tifm_sd.o
> obj-$(CONFIG_MMC_SPI) += mmc_spi.o
>
As this is a new driver, independent of the old one, wouldn't it make more sense with separate options? One CONFIG_MMC_OMAP and one CONFIG_MMC_OMAP_HS. Then you can specify the relevant dependencies in Kconfig, where they belong.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
