ext David Cohen wrote:
> Removing unused variable and useless comment from
> arch/arm/mach-omap1/board-h3-mmc.c file.
>
> Signed-off-by: David Cohen <david.cohen@xxxxxxxxxxx>
> ---
> arch/arm/mach-omap1/board-h3-mmc.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-h3-mmc.c b/arch/arm/mach-omap1/board-h3-mmc.c
> index 66ecc43..9f98a3a 100644
> --- a/arch/arm/mach-omap1/board-h3-mmc.c
> +++ b/arch/arm/mach-omap1/board-h3-mmc.c
> @@ -36,8 +36,6 @@ static int h3_mmc_set_power(struct device *dev, int slot, int power_on,
>
> static int h3_mmc_set_bus_mode(struct device *dev, int slot, int bus_mode)
> {
> - int ret = 0;
> -
> #ifdef CONFIG_MMC_DEBUG
> dev_dbg(dev, "Set slot %d bus_mode %s\n", slot + 1,
> bus_mode == MMC_BUSMODE_OPENDRAIN ? "open-drain" : "push-pull");
> @@ -47,8 +45,6 @@ static int h3_mmc_set_bus_mode(struct device *dev, int slot, int bus_mode)
> return -ENODEV;
> }
>
> - /* Treated on upper level */
> -
> return bus_mode;
> }
>
>
Hi David,
Regarding such patch, I'm aware of these unused and uninitialized
variables and others on board-*-mmc.c files.
Just to let you know, after concluding the multislot support on my list
of pending boards (Innovator 1510 and H4), I will send a clean-up patch
to move out such problems.
BR,
Carlos.
--
Carlos Eduardo Aguiar
Nokia Institute of Technology - INdT
Open Source Mobile Research Center - OSMRC - Manaus
Core Team
Phone: +55 92 2126-1079
Mobile: +55 92 8127-1797
E-mail: carlos.aguiar@xxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
