On Fri, 14 Dec 2007 21:45:26 +0530, "Gadiyar, Anand" <gadiyar@xxxxxx> wrote: <snip> > Can you clarify this a little? Do you mean declare it in the .h as: extern void sdp3430_usb_init(void); Yes. Removing __init and friends from header files is actually one of Kernel Janitors TODO. We don't need to redefine __init and friends on function prototypes. GCC will always use the last one. Redefining in header files can lead to errors like declaring the function as __init in the c file and __initdata in the header file and we can't be sure about which one GCC will use (not that true). The best here and for any other function, is leaving section defines to C files and avoid indirect including of linux/init.h -- Best Regards, Felipe Balbi http://felipebalbi.com me@xxxxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
