Hi Anand, On Dec 12, 2007 9:40 AM, Gadiyar, Anand <gadiyar@xxxxxx> wrote: > Hi Eduardo, > > > Felipe alread sent an updated patch with your suggestion. However, > > I'd proposed changing the read/write methods to be inline. Check this patch. > > Making those functions inline in the patch you sent won't really help, will it? No no, I've messed the topics up here. Sorry. I was just adding one more improvement to the control.h. > You still need to include the functions in the file omap_uds.c for them to be usable. That's true. And I agree with you: it looks horrible. I believe that this is the reason why Felipe sent his first patch in that way. :) Another way to do it is to export these methods somewhere under include/*. > > Maybe there's a better fix. That #include does look horrible. > > Cheers, > Anand > -- Eduardo Bezerra Valentin - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
