Hi Anand, Felipe alread sent an updated patch with your suggestion. However, I'd proposed changing the read/write methods to be inline. Check this patch. Cheers, On Dec 12, 2007 7:59 AM, Gadiyar, Anand <gadiyar@xxxxxx> wrote: > > > > b/drivers/usb/gadget/omap_udc.c index 2e8775e..e197900 100644 > > > > --- a/drivers/usb/gadget/omap_udc.c > > > > +++ b/drivers/usb/gadget/omap_udc.c > > > > @@ -2272,7 +2272,7 @@ static int proc_otg_show(struct seq_file *s) > > > > * do with the frame adjustment counter and McBSP2. > > > > */ > > > > ctrl_name = "control_devconf"; > > > > - trans = ctrl_read_reg(CONTROL_DEVCONF0); > > > > + trans = omap_readl(OMAP2_CONTROL_DEVCONF0); > > > > > > Shouldn't this be > > > + trans = ctrl_read_reg(OMAP2_CONTROL_DEVCONF0); > > > > I believe Balbi changed the function call because the > > read/write methods for ctrl register is not exported anymore. > > If you check under arch/arm/mach-omap2/control.h, they are > > static. Of course, we can change it to be exported, but with > > this patch it just do not touch the api. > > They never were exported. They were always static. That file was touched > exactly once - when it was introduced. > > I think the correct fix would be to use ctrl_read_reg and additionally, > to #include "arch/arm/mach-omap2/control.h" in the omap_udc.c file. > > That seems to be how those changes got done in the other files touched > by Paul Walmsley's commits. > > > My $0.02, > Anand > -- Eduardo Bezerra Valentin - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
