Hi all, I'm resending this patch with the #else removed. I'm also sending a few other ways in which we could do this. Option 1: Same patch as the last time without the #else This contains lots of #ifdef statements but there are no #elses Option 2: No #ifdefs. Using OMAP242X_* for 2420 specific names OMAP243X_* for 2430 specific names/names present from 243X onwards OMAP24XX_* for names common to all 24XX, 34XX OMAP34XX_* for 34XX specific names (or something similar could be worked out) Option 3: Name all possible names OMAP_* (or OMAP2_*) and use a runtime check to return the correct request line number. I'm sending sample patches for all three options. Let me know what you think. Regards, Anand - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html