RE: [RFC/PATCH 1/4] MMC/SD Controller driver for OMAP2430

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: linux-omap-open-source-bounces@xxxxxxxxxxxxxx [mailto:linux-omap-
> open-source-bounces@xxxxxxxxxxxxxx] On Behalf Of Carlos Aguiar
> Sent: Friday, December 07, 2007 8:24 PM
> To: Chikkature Rajashekar, Madhusudhan
> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-omap-open-source@xxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; 'Pierre Ossman'
> Subject: Re: [RFC/PATCH 1/4] MMC/SD Controller driver for OMAP2430
> 
> ext Madhusudhan Chikkature Rajashekar wrote:
> > This patch adds MMC controller driver for OMAP2430/3430.
> >
> > Signed-off-by: Madhusudhan Chikkature<madhu.cr@xxxxxx>
> >
> > ---
> >  drivers/mmc/host/Makefile     |    9
> >  drivers/mmc/host/omap_hsmmc.c |  985
> ++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 993 insertions(+), 1 deletion(-)
> >
> > Index: linux-omap-2.6/drivers/mmc/host/omap_hsmmc.c
> > ===================================================================

<snip>

> >
> Hi Madhu,
> 
> I'd rather see this code using multislot structures and omap.c instead
> of defining a whole new codebase for omap2430 and/or omap3.
> 
> BR,
> 
> Carlos.
> 
> 
Hi Carlos,

Thanks for comments.

I remember we had discussed this before as well, as communicated before the MMC/SD controller on OMAP2430 and 3430 processors is completely different( in Register width, bits, offsets, configuration etc) from OMAP2420 and OMAP1 platforms. It's not recommended to add new MMC controller functionality to existing omap.c. 

Yes we will definitely use multi-slot structures. We can add multi-slot support after we get formal approval of this code base.

Thanks & Regards,
Khasim
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux