Re: [PATCH 3/3] ARM: OMAP: Add MUSB support for OMAP34xx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Gadiyar, Anand" <gadiyar@xxxxxx> writes:

> This patch adds MUSB support for OMAP34XX.

[...]

> +static void musb_do_idle(unsigned long _musb)
> +{
> +	struct musb	*musb = (void *)_musb;
> +	unsigned long	flags;
> +	u8	power;
> +	u8	devctl;
> +
> +	devctl = musb_readb(musb->mregs, MUSB_DEVCTL);
> +
> +	spin_lock_irqsave(&musb->lock, flags);

This lock is never unlocked.

Might I recommend you turn on CONFIG_PREEMPT, and spinlock debugging
when testing.  The various lock debugging features in the 'Kernel
Hacking' menu are extremely useful for this kind of thing.

Kevin


-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux