Hi, here the patch Thanks in advance Bye, David Arendt > Hi, > On Wed, 7 Apr 2010 12:39:39 +0200, admin@xxxxxxxxx wrote: >> Hi, >> >> At the moment of submitting my cleaner patches, I didn't know if you >> would >> use the new behavior as default behavior or the old one therefore in >> documentation I had described that min_clean_segments = 0 would mean >> normal cleaner behavior. However as the new behavior is now used as >> default behavior, normal behavior might be confusing. > > That's right. > >> I am thinking about doing the following changes in documentation: >> >> in nilfs_cleanerd.conf change >> >> # Minium number of clean segments >> # 0 = normal cleaner behaviour >> # >0 = start cleaning if less segments are available >> min_clean_segments 10% >> >> to >> >> # Minimum number of clean segments >> # 0 = continuous cleaning >> # > 0 = pause cleaning until less segments are available >> min_clean_segments 10% >> >> I just saw that I had a typo in the word minimum. >> >> in nilfs_cleanerd.conf.8 change >> >> .B min_clean_segments >> Specify the minimum number of clean segments. A value of 0 means >> normal cleaner operation. A value greater than 0 means pause cleaning >> until less than min_clean_segments are available. >> >> to >> >> .B min_clean_segments >> Specify the minimum number of clean segments. A value of 0 means >> continuous cleaning. A value greater than 0 means pause cleaning >> until less than min_clean_segments are available. >> >> What do you think about it ? >> >> If you want to change, will you do changes or should I send you a patch >> ? > > Well, that change would be better. > Send me the patch, please? > > Thanks, > Ryusuke Konishi >
diff -ur nilfs2-utils.orig/man/nilfs_cleanerd.conf.5 nilfs2-utils/man/nilfs_cleanerd.conf.5 --- nilfs2-utils.orig/man/nilfs_cleanerd.conf.5 2010-04-08 06:27:04.652095525 +0200 +++ nilfs2-utils/man/nilfs_cleanerd.conf.5 2010-04-08 12:33:39.940330908 +0200 @@ -27,8 +27,8 @@ .TP .B min_clean_segments Specify the minimum number of clean segments. A value of 0 means -normal cleaner operation. A value greater than 0 means pause cleaning -until less than min_clean_segments are available. +continuous cleaning. A value greater than 0 means pause cleaning until +less than min_clean_segments are available. .TP .B max_clean_segments Specify the maximum number of clean segments. If min_clean_segments is diff -ur nilfs2-utils.orig/sbin/cleanerd/nilfs_cleanerd.conf nilfs2-utils/sbin/cleanerd/nilfs_cleanerd.conf --- nilfs2-utils.orig/sbin/cleanerd/nilfs_cleanerd.conf 2010-04-08 06:27:04.653095645 +0200 +++ nilfs2-utils/sbin/cleanerd/nilfs_cleanerd.conf 2010-04-08 12:39:13.178765756 +0200 @@ -11,9 +11,9 @@ # Protection period in second. protection_period 3600 -# Minium number of clean segments -# 0 = normal cleaner behaviour -# >0 = start cleaning if less segments are available +# Minimum number of clean segments +# 0 = continuous cleaning +# > 0 = pause cleaning until less segments are available min_clean_segments 10% # Maximum number of clean segments
