On Thu, 8 Apr 2010 13:45:05 +0800, Li Hong <lihong.hi@xxxxxxxxx> wrote: > 2010/4/8 Ryusuke Konishi <ryusuke@xxxxxxxx>: > > On Wed, 7 Apr 2010 22:20:58 +0800, Li Hong <lihong.hi@xxxxxxxxx> wrote: > >> Hi KONISHI Ryusuke, > >> > >> Any feedbacks on these patches? > >> > >> Thanks, > >> Li Hong > > > > Well, adding a load message is ok, but it should be more moderate like > > "nilfs2 file system loaded\n". > Yes. I just thought that printing a message after loading a file > system is a practice. > You may choose any string that you think is suitable :) How about "NILFS version 2 loaded\n" ? Seems that most messages have prefix "NILFS: ..." or "NILFS (device %s):". > > I think this sort of change should be discussed in the sub topic > > mailing list (i.e. linux-nilfs). You don't have to cc every patch to > > linux-kernel. > Ok. No problem. > > > And, please include some explanation in the change log to clarify the > > aim or motivation. > I took it as a very simple patch and thought a header was enough. I can add more > explanations if here has a demand. You thought "printing a message after loading a file system is a practice.", so it is the reason :) Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html