On Fri, Jul 17, 2020 at 01:34:03PM -0400, Steve Dickson wrote: > Hey Doug, > > On 7/16/20 5:36 PM, Doug Nazar wrote: > > I was looking through the README to ensure my systems followed the correct setup and noticed a few things. > > > > Looks like the reference to libnfsidmap can be dropped. > > > > It looks like nfsdcld is again the correct setup for client tracking. A section should be added to SERVER STARTUP to include nfsdcld on NFS4+ servers. > > > > Should it mention which modules are required before starting? I've had to locally add 'auth_rpcgss' to my startup scripts or svcgssd will bail on startup. > > > > Any other changes or best practices that should be mentioned before I send a patch? > > Yes... the README is dreadfully out of date... although most of it has > not changed but a lot has... esp when it comes to the systemd set up.. > although the systemd/README is pretty accurate... Maybe a point to > the systemd/README in the top README would be good. > > What script did you have to add 'auth_rpcgss' to? > It should be automatically be loaded when the sunrpc > module is loaded. Yes, looking at that out of curiosity... there's a request_module() in net/sunrpc/auth.c that should be trying to load "rpc-auth-6". Together with the MODULE_ALIAS("rpc-auth-6") in net/sunrpc/auth_gss/auth_gss.c, that should make this automatic. --b.