On Tue, Jul 14, 2015 at 12:22:14PM +0300, Sagi Grimberg wrote: > It's better if you want it fast. I can't stress it enough, but IMO, the > fallback should *not* be in the API, but rather in the ULP. > Ideally, at some point it won't need to fall back, and we can remove > the API. But if all driver need to impement the same dispatch between FR/FMR/ALLPHYS and having similar fast path hacks something is wrong. Maybe we should start but just implementing the helper you suggest in separae FR/FMR/ALLPHYS handlers while phasing out hacks like use ALLPHYS for single segment registrations or if other registrations fail. And as a second step we can decide if their are similar enough to consolidate them, or if we should simply kick out FMR and/or ALLPHYS and thus not support any in-kernel consumers for old HCAs. n the meantime let's kick off the now aready unuses memwindow in-kernel API (I fear the userlevel one will have to stay forever) and the about to be unused by proper in-kernel code PHYS MRs. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
