On 7/8/2015 12:36 AM, Jason Gunthorpe wrote:
On Tue, Jul 07, 2015 at 07:27:47PM +0300, Sagi Grimberg wrote:
Doesn't it look odd to you?
Sure, but the oddness is that rdma_device_access_flags exists at all,
not the wrapper. The wrapper is what we want the API to look like,
I don't necessarily agree. The API we'd want is a single API at all
the call sites to all types of MRs. We have different QP types, and
still we don't have an allocation API for each and every one.
I honestly don't see why we have that for MRs.
If we can converge to a single API for MR allocation we can just get it
right once.
if we could trivially change the WR format as well then
rdma_device_access_flags wouldn't even exist at all.
I have taken some time to truly think about that following Christoph's
comments to my indirect registration patches. This is one of the things
I'm looking at.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
