On 7/7/2015 12:00 PM, Christoph Hellwig wrote:
On Mon, Jul 06, 2015 at 07:17:38PM +0300, Sagi Grimberg wrote:
Ok. I'll remove all uses of ib_get_dma_mr()...
I meant that rdma_get_dma_mr can go away. I'd prefer to get the
needed access_flags and just call existing verb.
I strongly disagree. As this series has shown the existing API is not
epressive enough for all transports. It thus needs to go away and be
fully replaced by the new API introduced here.
Christoph,
I wasn't arguing about having a transport independent API. I was
referring to this wrapper specifically that trampolines to
ib_get_dma_mr() with rdma_device_access_flags(pd, roles, attrs) helper.
The rdma_device_access_flags() itself is fine. However, given that
this helper is used elsewhere as well, I don't see the point of having
yet another helper specifically just for the dma_mr case that does
nothing more than trampolines with a call to rdma_device_access_flags().
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
