On 7/7/2015 7:17 PM, Jason Gunthorpe wrote:
On Tue, Jul 07, 2015 at 09:05:15AM -0500, Steve Wise wrote:
I took the feedback from Christoph and Jason to mean I should remove
ib_get_dma_mr() entirely and pull its guts into rdma_get_dma_mr(),
and change all the users of ib_get_dma_mr() to use
rdma_get_dma_mr(). So the net result isn't a wrapper. It would of
course still use rdma_device_access_flags()...
Right, to the greatest extent possible.
Keeping ib_get_dma_mr and the old flags around just means someone
could go back and use the old flags.
It looks strange to me that there is a helper to get a transport
independent access_flags rdma_device_access_flags() that helps the
user to choose the correct access_flags for MR creation and fast
registration (which is more than OK), and having a wrapper that just
hides it from the user...
Doesn't it look odd to you?
I expect well need to keep the driver entry point for user space, but
we should be able to hide the API and flags from other modules.
dma_mr for user-space?? How can this be relevant for user-space?
A wrapper is a reasonable way to stage through that transition..
I can't say that I completely agree here.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
