On Mon, Jul 13, 2015 at 03:36:44PM -0400, Tom Talpey wrote: > On 7/11/2015 6:25 AM, 'Christoph Hellwig' wrote: > >I think what we need to support for now is FRMR as the primary target, > >and FMR as a secondar[y]. > > FMR is a *very* bad choice, for several reasons. > > 1) It's not supported by very many devices, in fact it might even > be thought to be obsolete. It's support by the Mellanox adapters, which might be a minority of the drivers, but at least in the field I've been in the aboslute majority of the deployed hardware. It's the default in the SRP initiator and iSER initiators, and the primary fallback in the NFS client if FRs aren't available. I don't claim to be an expert on memory registrations models, as they are horribly, horrible documents (baiscally not at all in the source tree), so my knowledge is from looking at and using implementations as well as this useful writeup from the NFS folks: http://wiki.linux-nfs.org/wiki/index.php/NfsRdmaClient/MemRegModes Which misses or downplays an important restriction of PHYS registrations: They dont allow coalescing non-contiguous memory into a single maping, which makes them totally unsuitable for iSER which only allows a single rkey/offset/len pair and requires additional RDMA READ/WRITE roundtrips and larger S/G lists for other protocols. Based on looking at the consumers and the above table I think FMR are still the better fallback for devices that don't support FR, but supporting PHYS MRs is easy enough that adding it to a common layer seems easy enough if some cares enough to regularly test it. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html